Re: [PATCH -next] drm/ast: make ast_modeset static
From: Ruan Jinjie
Date: Mon Sep 26 2022 - 03:38:38 EST
Thank you very much!
On 2022/9/26 15:16, Thomas Zimmermann wrote:
> Hi
>
> Am 26.09.22 um 04:32 schrieb ruanjinjie:
>> The symbol is not used outside of the file, so mark it static.
>>
>> Fixes the following warning:
>>
>> drivers/gpu/drm/ast/ast_drv.c:42:5: warning: symbol 'ast_modeset'
>> was not declared. Should it be static?
>>
>> Signed-off-by: ruanjinjie <ruanjinjie@xxxxxxxxxx>
>
> Thank you. Added to drm-misc-next.
>
> Best regards
> Thomas
>
>> ---
>> drivers/gpu/drm/ast/ast_drv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/ast/ast_drv.c
>> b/drivers/gpu/drm/ast/ast_drv.c
>> index 760b27971557..b9392f31e629 100644
>> --- a/drivers/gpu/drm/ast/ast_drv.c
>> +++ b/drivers/gpu/drm/ast/ast_drv.c
>> @@ -39,7 +39,7 @@
>> #include "ast_drv.h"
>> -int ast_modeset = -1;
>> +static int ast_modeset = -1;
>> MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
>> module_param_named(modeset, ast_modeset, int, 0400);
>