Re: [PATCH] mm: fix misuse of update_mmu_cache() in do_anonymous_page()

[Qi Zheng]

On 2022/9/26 16:42, David Hildenbrand wrote:
> On 26.09.22 10:41, Qi Zheng wrote:
> > On 2022/9/26 16:32, David Hildenbrand wrote:
> > > On 25.09.22 03:43, Muchun Song wrote:
> > > > > On Sep 24, 2022, at 13:32, Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx> 
> > > > > wrote:
> > > > >
> > > > > As message in commit 7df676974359 ("mm/memory.c: Update local TLB
> > > > > if PTE entry exists") said, we should update local TLB only on the
> > > > > second thread. So fix the misuse of update_mmu_cache() by using
> > > > > update_mmu_tlb() in the do_anonymous_page().
> > > > >
> > > > > Signed-off-by: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>
> > > >
> > > > The change looks good to me. However, I am not sure what is the
> > > > user-visible
> > > > effect to xtensa users. So Cc xtensa’s maintainer and the author of
> > > > 7df676974359
> > > > to double check this.
> > >
> > > And if there is one, do we have a fixes tag?
> >
> > IIUC, there's only a performance difference here, so maybe there's no
> > need to add the fixes tag?
>
> Maybe be careful with the usage of "fix" in subject/description then and 
> point that out in the description :)

Ah, will change subject/description in the v2, thanks. :)

>

--
Thanks,
Qi