Re: [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types

From: Krzysztof Kozlowski
Date: Mon Sep 26 2022 - 04:51:56 EST


On 25/09/2022 23:17, Luca Weiss wrote:

Thank you for your patch. There is something to discuss/improve.

> additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet
>
> + "charger@[0-9a-f]+$":
> + type: object
> + oneOf:
> + - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
> + - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
> +
> + "^dcdc@[0-9a-f]+$":
> + type: object

How about renaming this one to usb-vbus-regulator?

Best regards,
Krzysztof