Re: [PATCH 5.19 014/207] Revert "usb: add quirks for Lenovo OneLink+ Dock"

From: Jiri Slaby
Date: Tue Sep 27 2022 - 02:18:37 EST


On 27. 09. 22, 7:47, Greg Kroah-Hartman wrote:
On Tue, Sep 27, 2022 at 07:23:46AM +0200, Jiri Slaby wrote:
I wonder, does it make sense to queue the commit (as 011/207) and
immediately its revert (the patch below) in a single release? I doubt
that...

The same holds for 012 (patch) + 015 (revert).

Yes it does, otherwise tools will pick up "hey, you forgot this patch
that should have been applied here!" all the time. Having the patch,
and the revert, in the tree prevents that from happening.

It'd be fairly easy to fix the tools not to pick up reverted commits, right?

thanks,
--
js
suse labs