RE: [RESEND PATCH v3 6/7] dt-bindings: spi: spi-zynqmp-qspi: Add support for Xilinx Versal QSPI

[Mahapatra, Amit Kumar]

Hello Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Monday, September 26, 2022 2:32 PM
> To: Amit Kumar Mahapatra <amit.kumar-mahapatra@xxxxxxxxxx>;
> broonie@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx
> Cc: Mahapatra, Amit Kumar <amit.kumar-mahapatra@xxxxxxx>; git (AMD-
> Xilinx) <git@xxxxxxx>; michal.simek@xxxxxxxxxx; linux-spi@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; Mahapatra, Amit Kumar <amit.kumar-
> mahapatra@xxxxxxx>
> Subject: Re: [RESEND PATCH v3 6/7] dt-bindings: spi: spi-zynqmp-qspi: Add
> support for Xilinx Versal QSPI
> 
> On 26/09/2022 08:33, Amit Kumar Mahapatra wrote:
> > Add new compatible to support QSPI controller on Xilinx Versal SoCs.
> 
> Use subject prefixes matching the subsystem (git log --oneline -- ...).
> 
> This is still not fixed.
I missed this comment in the previous version. I will fix it & send the next version.

Thanks,
Amit
> 
> >
> > Signed-off-by: Amit Kumar Mahapatra <amit.kumar-
> mahapatra@xxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> > index fafde1c06be6..5ed651084896 100644
> > --- a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> > @@ -14,7 +14,9 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    const: xlnx,zynqmp-qspi-1.0
> > +    enum:
> > +      - xlnx,versal-qspi-1.0
> > +      - xlnx,zynqmp-qspi-1.0
> 
> With fixed subject:
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> 
> Best regards,
> Krzysztof