Re: [PATCH 5.4 097/120] gpio: ixp4xx: Make irqchip immutable

From: Sasha Levin
Date: Wed Sep 28 2022 - 12:22:55 EST


On Mon, Sep 26, 2022 at 05:58:49PM +0200, Greg Kroah-Hartman wrote:
On Mon, Sep 26, 2022 at 06:40:02AM -0400, Marc Zyngier wrote:
Greg,

On Mon, 26 Sep 2022 06:12:10 -0400,
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> From: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> [ Upstream commit 94e9bc73d85aa6ecfe249e985ff57abe0ab35f34 ]
>
> This turns the IXP4xx GPIO irqchip into an immutable
> irqchip, a bit different from the standard template due
> to being hierarchical.
>
> Tested on the IXP4xx which uses drivers/ata/pata_ixp4xx_cf.c
> for a rootfs on compact flash with IRQs from this GPIO
> block to the CF ATA controller.
>
> Cc: Marc Zyngier <maz@xxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Acked-by: Marc Zyngier <maz@xxxxxxxxxx>
> Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

We had that discussion[1], and concluded that none of these should be
backported to a kernel earlier than 5.19. 5.4 doesn't currently
contain the relevant infrastructure, nor should that infrastructure
should be backported either.

Can we *please* stop this?

M.

[1] https://lore.kernel.org/all/CAMRc=Md9JKdW8wmbun_0_1y2RQbck7q=vzOkdw6n+FBgpf0h8w@xxxxxxxxxxxxxx/

Sasha, what went wrong here?

Now dropped from all but 5.19.y, thanks.

Sorry about that, I misunderstood Bartosz's reply and went off based on
that.

--
Thanks,
Sasha