Re: [PATCH 5/8] soc: mediatek: mtk-svs: Move SoC specific functions to new files

[AngeloGioacchino Del Regno]

Il 28/09/22 17:55, matthias.bgg@xxxxxxxxxx ha scritto:
> From: Matthias Brugger <matthias.bgg@xxxxxxxxx>
>
> With every SoC added to the driver, it grows. Move SoC specific
> callbacks to a new source files.
>
> Signed-off-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> ---
>
>   drivers/soc/mediatek/Makefile         |   3 +-
>   drivers/soc/mediatek/mt8183-svs.h     | 113 ++++
>   drivers/soc/mediatek/mt8192-svs.h     |  64 ++
>   drivers/soc/mediatek/mtk-svs-mt8183.c | 234 ++++++++
>   drivers/soc/mediatek/mtk-svs-mt8192.c | 100 ++++
>   drivers/soc/mediatek/mtk-svs.c        | 831 ++------------------------
>   drivers/soc/mediatek/mtk-svs.h        | 279 +++++++++
>   7 files changed, 837 insertions(+), 787 deletions(-)
>   create mode 100644 drivers/soc/mediatek/mt8183-svs.h
>   create mode 100644 drivers/soc/mediatek/mt8192-svs.h
>   create mode 100644 drivers/soc/mediatek/mtk-svs-mt8183.c
>   create mode 100644 drivers/soc/mediatek/mtk-svs-mt8192.c
>   create mode 100644 drivers/soc/mediatek/mtk-svs.h
>
> diff --git a/drivers/soc/mediatek/Makefile b/drivers/soc/mediatek/Makefile
> index 0e9e703c931a..851131638644 100644
> --- a/drivers/soc/mediatek/Makefile
> +++ b/drivers/soc/mediatek/Makefile
> @@ -7,4 +7,5 @@ obj-$(CONFIG_MTK_SCPSYS) += mtk-scpsys.o
>   obj-$(CONFIG_MTK_SCPSYS_PM_DOMAINS) += mtk-pm-domains.o
>   obj-$(CONFIG_MTK_MMSYS) += mtk-mmsys.o
>   obj-$(CONFIG_MTK_MMSYS) += mtk-mutex.o
> -obj-$(CONFIG_MTK_SVS) += mtk-svs.o
> +mtk_svs-objs := mtk-svs.o mtk-svs-mt8183.o mtk-svs-mt8192.o
> +obj-$(CONFIG_MTK_SVS) += mtk_svs.o
> diff --git a/drivers/soc/mediatek/mt8183-svs.h b/drivers/soc/mediatek/mt8183-svs.h
> new file mode 100644
> index 000000000000..89c0deb9fb11
> --- /dev/null
> +++ b/drivers/soc/mediatek/mt8183-svs.h
> @@ -0,0 +1,113 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +
> +#ifndef __DRV_SVS_MT8183_H
> +#define __DRV_SVS_MT8183_H
> +

Please avoid implicit header inclusion (here and in mt8192-svs.h).

#include "mtk-svs.h"

Cheers,
Angelo