Re: [PATCH v2] Documentation: kunit: rewrite writing first test instructions

From: David Gow
Date: Sat Oct 01 2022 - 02:51:57 EST

On Sat, Oct 1, 2022 at 11:07 AM Bagas Sanjaya <bagasdotme@xxxxxxxxx> wrote:
> On 9/30/22 17:32, David Gow wrote:
> >>
> >> The indentation for code-block directive is required, since the preceding
> >> paragraph is multiline; otherwise there will be Sphinx warnings.
> >>
> >
> > I don't see any such warnings on my machine (which claims to have
> > sphinx-build 4.5.0).
> >
> > Could you send an example warning, and your sphinx version to me so I
> > can try to reproduce it.
> >
> > Regardless, if it's causing warnings, keep these changes. (Though it'd
> > be nice to include the warnings in the commit message, so it's obvious
> > that these are being re-aligned for a reason.)
> >
> I'm using Sphinx 2.4.4 (as installed from pip through
> Documentation/sphinx/requirements.txt).
> Sorry I can't reproduce the warning I mentioned earlier (I forget
> the recipe that triggers it when writing the improv).
> In any case, I'd like to keep code block aligning in the separate patch.
> It would be nice to see code blocks aligned to the instructions list.

Sounds good. I tried to read through the reStructuredText spec to see
what it said about indentation here, and it was pretty vague, but if
it's causing warnings, we definitely should fix it. It would be nicer
(though not essential) to have it as a separate patch to the other
content changes.

Either way, feel free to send a new version (ideally based on top of
the kselftest/kunit tree, which has just had a number of patches
merged, including v1 of [1]).

-- David


Attachment: smime.p7s
Description: S/MIME Cryptographic Signature