Re: [PATCH v2 3/4] dt-bindings: net: qcom,ethqos: Convert bindings to yaml

[Bhupesh Sharma]

On 9/30/22 3:56 PM, Krzysztof Kozlowski wrote:
> On 30/09/2022 10:12, Bhupesh Sharma wrote:
> > > > +  snps,reset-gpio:
> > > > +    maxItems: 1
> > >
> > > Why is this one here? It's already in snps,dwmac.
> > >
> > > Actually this applies to several other properties. You have
> > > unevaluatedProperties:false, so you do not have to duplicate snps,dwmac.
> > > You only need to constrain it, like we said about interrupts in your
> > > previous patch.
> >
> > I was actually getting errors like the following without the same:
> >
> > arm64/boot/dts/qcom/qcs404-evb-1000.dtb: ethernet@7a80000: Unevaluated
> > properties are not allowed ('snps,tso' was unexpected)
> > 	From schema: Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> >
> > So, its not clear to me that even though 'snps,dwmac.yaml' is referenced
> > here, the property appears as unevaluated.
>
> Because snps,tso is not allowed, but the rest is.
>
> > > > +
> > > > +  power-domains:
> > > > +    maxItems: 1
> > > > +
> > > > +  resets:
> > > > +    maxItems: 1
> > > > +
> > > > +  rx-fifo-depth:
> > > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > > +
> > > > +  tx-fifo-depth:
> > > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > > +
> > > > +  snps,tso:
> > > > +    type: boolean
> > > > +    description: Enables the TSO feature (otherwise managed by MAC HW capability register).
> > >
> > > You add here several new properties. Mention in commit msg changes from
> > > pure conversion with answer to "why".
> >
> > Right, most of them are to avoid the make dtbs_check errors / warnings
> > like the one mentioned above.
>
> All of them should not be here.

I guess only 'snps,reset-gpio' need not be replicated here, as for 
others I still see 'dtbs_check' error, if they are not replicated here:


arch/arm64/boot/dts/qcom/sm8150-hdk.dtb: ethernet@20000: Unevaluated 
properties are not allowed ('power-domains', 'resets', 'rx-fifo-depth', 
'tx-fifo-depth' were unexpected)
	From schema: /Documentation/devicetree/bindings/net/qcom,ethqos.yaml

Am I missing something here?

Thanks.