Re: [PATCH v2] dt-bindings: net: marvell,pp2: convert to json-schema

From: Michał Grzelak
Date: Sat Oct 01 2022 - 11:54:31 EST

Hi Krzysztof,

Thanks for your comments and time spent on reviewing my patch.
All of those improvements will be included in next version.
Also, I would like to know your opinion about one.

>> +
>> + marvell,system-controller:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description: a phandle to the system controller.
>> +
>> +patternProperties:
>> + '^eth[0-9a-f]*(@.*)?$':
> The name should be "(ethernet-)?port", unless anything depends on
> particular naming?

What do you think about pattern "^(ethernet-)?eth[0-9a-f]+(@.*)?$"?
It resembles pattern found in net/ethernet-phy.yaml like
properties:$nodename:pattern:"^ethernet-phy(@[a-f0-9]+)?$", while
still passing `dt_binding_check' and `dtbs_check'. It should also
comply with your comment.

Best regards,