Re: [PATCH v6 07/13] i2c: acpi: Use ACPI wake capability bit to set wake_irq

From: Wolfram Sang
Date: Sat Oct 01 2022 - 18:51:38 EST

On Thu, Sep 29, 2022 at 10:19:11AM -0600, Raul E Rangel wrote:
> Device tree already has a mechanism to pass the wake_irq. It does this
> by looking for the wakeup-source property and setting the
> I2C_CLIENT_WAKE flag. This CL adds the ACPI equivalent. It uses the
> ACPI interrupt wake flag to determine if the interrupt can be used to
> wake the system. Previously the i2c drivers had to make assumptions and
> blindly enable the wake IRQ. This can cause spurious wake events. e.g.,
> If there is a device with an Active Low interrupt and the device gets
> powered off while suspending, the interrupt line will go low since it's
> no longer powered and wakes the system. For this reason we should
> respect the board designers wishes and honor the wake bit defined on the
> interrupt.
> Signed-off-by: Raul E Rangel <rrangel@xxxxxxxxxxxx>
> Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

I assume this goes in with the rest of this series, so:

Acked-by: Wolfram Sang <wsa@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature