Re: [PATCH v6 1/3] iio: adc: add max11410 adc driver
From: Jonathan Cameron
Date: Sun Oct 02 2022 - 09:14:00 EST
On Tue, 27 Sep 2022 17:18:49 +0300
Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx> wrote:
> Adding support for max11410 24-bit, 1.9ksps delta-sigma adc which
> has 3 differential reference and 10 differential channel inputs.
> Inputs and references can be buffered internally. Inputs can also
> be amplified with internal PGA.
> Device has four digital filter modes: FIR50/60, FIR50, FIR60 and SINC4.
> FIR 50Hz and 60Hz rejections can be enabled/disabled separately.
> Digital filter selection affects sampling frequency range so driver
> has to consider the configured filter when configuring sampling frequency.
> Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx>
Other than the obvious (form the build bug report) missing
this looks good to me. I may of course spot something on v7, but hopefully
we can get the binding issues resolved and get this queued up.