Re: [PATCH] scsi: core: Add BLIST_NO_ASK_VPD_SIZE for some VDASD

From: Bart Van Assche
Date: Sun Oct 02 2022 - 17:16:29 EST

On 9/28/22 11:13, Lee Duncan wrote:
From: Lee Duncan <lduncan@xxxxxxxx>

Some storage, such as AIX VDASD (virtual storage) and IBM 2076
(front end) do not like the recent commit:

commit c92a6b5d6335 ("scsi: core: Query VPD size before getting full page")

That commit changed getting SCSI VPD pages so that we now read
just enough of the page to get the actual page size, then read
the whole page in a second read. The problem is that the above
mentioned hardware returns zero for the page size, because of
a firmware error. In such cases, until the firmware is fixed,
this new black flag says to revert to the original method of
reading the VPD pages, i.e. try to read as a whole buffer's
worth on the first try.

Fixes: c92a6b5d6335 ("scsi: core: Query VPD size before getting full page")

Hi Lee,

If we introduce a blacklist flag to skip querying the VPD page size then we will have to find all SCSI devices that do not handle querying the VPD page size correctly. Has it been considered instead of introducing a blacklist flag to not use the reported VPD page size if the device reports that the VPD page size is zero? I am not aware of any VPD pages for which zero is a valid size.