Re: [PATCH net-next v2 4/6] net: microchip: sparx5: add support for apptrust

[Daniel.Machon]

> >> > Make use of set/getapptrust() to implement per-selector trust and trust
> >> > order.
> >> >
> >> > Signed-off-by: Daniel Machon <daniel.machon@xxxxxxxxxxxxx>
> >> > ---
> >> >  .../ethernet/microchip/sparx5/sparx5_dcb.c    | 116 ++++++++++++++++++
> >> >  .../ethernet/microchip/sparx5/sparx5_main.h   |   3 +
> >> >  .../ethernet/microchip/sparx5/sparx5_port.c   |   4 +-
> >> >  .../ethernet/microchip/sparx5/sparx5_port.h   |   2 +
> >> >  .../ethernet/microchip/sparx5/sparx5_qos.c    |   4 +
> >> >  5 files changed, 127 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c b/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
> >> > index db17c124dac8..10aeb422b1ae 100644
> >> > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
> >> > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
> >> > @@ -8,6 +8,22 @@
> >> >
> >> >  #include "sparx5_port.h"
> >> >
> >> > +static const struct sparx5_dcb_apptrust {
> >> > +     u8 selectors[256];
> >> > +     int nselectors;
> >> > +     char *names;
> >>
> >> I think this should be just "name".
> >
> > I dont think so. This is a str representation of all the selector values.
> > "names" makes more sense to me.
> 
> But it just points to one name, doesn't it? The name of this apptrust
> policy...

It points to a str of space-separated selector names.
I inteded it to be a str repr. of the selector values, and not a str
identifier of the apptrust policy. Maybe sel(ector)_names?

> 
> BTW, I think it should also be a const char *.

Ack.

> 
> >> > +} *apptrust[SPX5_PORTS];
> >> > +
> >> > +/* Sparx5 supported apptrust configurations */
> >> > +static const struct sparx5_dcb_apptrust apptrust_conf[4] = {
> >> > +     /* Empty *must* be first */
> >> > +     { { 0                         }, 0, "empty"    },
> >> > +     { { IEEE_8021QAZ_APP_SEL_DSCP }, 1, "dscp"     },
> >> > +     { { DCB_APP_SEL_PCP           }, 1, "pcp"      },
> >> > +     { { IEEE_8021QAZ_APP_SEL_DSCP,
> >> > +         DCB_APP_SEL_PCP           }, 2, "dscp pcp" },
> >> > +};
> >> > +