Re: [PATCH v2 tty-next 3/3] 8250: microchip: pci1xxxx: Add power management functions to quad-uart driver.
From: Andy Shevchenko
Date: Mon Oct 03 2022 - 05:32:25 EST
On Sat, Oct 1, 2022 at 9:15 AM Kumaravel Thiagarajan
<kumaravel.thiagarajan@xxxxxxxxxxxxx> wrote:
>
> pci1xxxx's quad-uart function has the capability to wake up the host from
> suspend state. Enable wakeup before entering into suspend and disable
> wakeup on resume.
...
> + port->suspended == 0
How is this check race-protected?
...
> +static void pci1xxxx_port_resume(int line)
> +{
> + if (port->suspended == 0) {
Ditto.
> + }
> +}
...
If you have similarities with 8250_pci, probably you need to split it
to 8250_pcilib.c and share. (See how 8250_dw /8250_lpss are done in
that sense.)
--
With Best Regards,
Andy Shevchenko