Re: [PATCH Part2 v6 13/49] crypto:ccp: Provide APIs to issue SEV-SNP commands
From: Borislav Petkov
Date: Mon Oct 03 2022 - 13:45:52 EST
On Mon, Oct 03, 2022 at 05:11:05PM +0000, Kalra, Ashish wrote:
> They are basically providing the APIs for the hypervisor to manage a
> SNP guest.
Yes, I know. But that is not my question. Lemme try again.
My previous comment was:
"I think you should simply export sev_do_cmd() and call it instead."
In this case, the API is a single function - sev_do_cmd() - which the
hypervisor calls.
So my question still stands: why is it better to have silly wrappers
of sev_do_cmd() instead of having the hypervisor call sev_do_cmd()
directly?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette