Re: [PATCH V1 0/4] GPIO based PCIe Hot-Plug support
From: Pali Rohár
Date: Mon Oct 03 2022 - 14:22:00 EST
On Monday 03 October 2022 13:09:49 Bjorn Helgaas wrote:
> On Sat, Oct 01, 2022 at 05:50:07PM -0600, Jonathan Derrick wrote:
> > On 10/1/2022 10:20 AM, Pali Rohár wrote:
> > ...
> > > Would not it better to rather synthesise PCIe Slot Capabilities support
> > > in your PCIe Root Port device (e.g. via pci-bridge-emul.c) and then let
> > > existing PCI hotplug code to take care for hotplugging? Because it
> > > already implements all required stuff for re-scanning, registering and
> > > unregistering PCIe devices for Root Ports with Slot Capabilities. And I
> > > think that there is no need to have just another (GPIO based)
> > > implementation of PCI hotplug.
> > I did that a few years ago (rejected), but can attest to the robustness of
> > the pcie hotplug code on non-hotplug slots.
> > https://lwn.net/Articles/811988/
> I think the thread is here:
> and I'm sorry that my response came across as "rejected". I intended
> it as "this is good ideas and good work and we should keep going".
Nice! So we have consensus that this is a good idea. Anyway, if you need
help with designing something here, please let me know as I have good
understanding of all (just two) consumers of pci-bridge-emul.c driver.