Re: [PATCH v6 3/3] pinctrl: qcom: add sdm670 pinctrl

[Richard Acayan]

> On Sat, Oct 01, 2022 at 05:07:25PM -0400, Richard Acayan wrote:
> > The Snapdragon 670 has a Top-Level Mode Multiplexer (TLMM) for various
> > features. Add a driver to support it.
> > 
> > Link: https://android.googlesource.com/kernel/msm/+/de5a12173c7fa6d65bedee9ad36af55b2dbfeb36%5E%21/#F6
> > Link: https://android.googlesource.com/kernel/msm/+/04f083156d9b9f3bfcf204c1c6da88632fbb3863%5E%21/#F22
> > Link: https://android.googlesource.com/kernel/msm/+/54837652e3400ecc63ccc78b2193faf4f349a32e%5E%21/#F0
> > Link: https://android.googlesource.com/kernel/msm/+/f0409b07174ceca217f8b7fd255418feff06092d%5E%21/#F0
> > Signed-off-by: Richard Acayan <mailingradian@xxxxxxxxx>
> 
> Pending the question about overriding reserved_gpios, the rest of this
> patch looks good.

Except for these somewhat inconsistent lines:

	static const char * const qdss_groups[] = {
		"gpio13", "gpio14", "gpio15", "gpio16", "gpio17", "gpio18", "gpio19",
		"gpio20", "gpio21", "gpio22", "gpio23", "gpio24", "gpio25", "gpio26",
		"gpio27", "gpio28", "gpio29", "gpio30", "gpio41", "gpio42", "gpio43",
		"gpio44", "gpio75", "gpio76", "gpio77", "gpio79", "gpio80", "gpio93",
		"gpio117", "gpio118", "gpio119", "gpio120", "gpio121", "gpio122",
		"gpio123", "gpio124",
	};

	static const char * const phase_flag_groups[] = {
		"gpio29",
		"gpio30",
		"gpio52",
		"gpio53",
		"gpio54",
		"gpio55",
		"gpio56",
		"gpio57",
		"gpio75",
		"gpio76",
		"gpio77",
		"gpio89",
		"gpio90",
		"gpio96",
		"gpio99",
		"gpio100",
		"gpio101",
		"gpio137",
		"gpio138",
		"gpio139",
		"gpio140",
		"gpio141",
		"gpio142",
		"gpio143",
	};

It should be this, will post tomorrow:

	static const char * const phase_flag_groups[] = {
		"gpio29", "gpio30", "gpio52", "gpio53", "gpio54", "gpio55", "gpio56",
		"gpio57", "gpio75", "gpio76", "gpio77", "gpio89", "gpio90", "gpio96",
		"gpio99", "gpio100", "gpio101", "gpio137", "gpio138", "gpio139",
		"gpio140", "gpio141", "gpio142", "gpio143",
	};

> 
> Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx>

Assuming this isn't invalidated by the above change.

> 
> Regards,
> Bjorn