Re: [PATCH] ARM: dts: armada-xp-98dx3236: add interrupts for watchdog

From: Chris Packham
Date: Mon Oct 03 2022 - 21:13:16 EST


Hi All,

On 4/10/22 10:24, Chris Packham wrote:
> The first interrupt is for the regular watchdog timeout. Normally the
> RSTOUT line will trigger a reset before this interrupt fires but on
> systems with a non-standard reset it may still trigger.
>
> The second interrupt is for a timer1 which is used as a pre-timeout for
> the watchdog.
>
> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>

I just realized this is a duplicate of
https://lore.kernel.org/linux-watchdog/20220211003257.2037332-2-chris.packham@xxxxxxxxxxxxxxxxxxx/
(I did have a strange sense of deja vu when writing it).

Looks like that patch was reviewed and acked but never delivered.
Gregory would you be able to pick it up now? The driver change has been
in for a while.

> ---
> arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> index 38a052a0312d..0e561dfc0ca9 100644
> --- a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> +++ b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> @@ -286,6 +286,7 @@ &watchdog {
> compatible = "marvell,armada-xp-wdt";
> clocks = <&coreclk 2>, <&refclk>;
> clock-names = "nbclk", "fixed";
> + interrupts = <93>, <38>;
> };
>
> &cpurst {