Re: [PATCH 11/20] gpio/rockchip: add of_node for gpiochip

From: Linus Walleij
Date: Tue Oct 04 2022 - 03:15:00 EST


On Tue, Sep 20, 2022 at 12:31 PM Jianqun Xu <jay.xu@xxxxxxxxxxxxxx> wrote:

> The Rockchip GPIO driver will probe before pinctrl and has no parent dt
> node, lack of the of_node will cause the driver probe failure.
>
> Signed-off-by: Jianqun Xu <jay.xu@xxxxxxxxxxxxxx>

> +#ifdef CONFIG_OF_GPIO
> + gc->of_node = of_node_get(bank->dev->of_node);
> +#endif

Any introduction of of_node_get() needs to be balanced with a
corresponding of_node_put().

Yours,
Linus Walleij