Re: [PATCH -next v2 1/2] pinctrl: ocelot: add missing destroy_workqueue() in error path in ocelot_pinctrl_probe()

[Horatiu Vultur]

The 10/04/2022 09:09, Linus Walleij wrote:

Hi Linus,

> 
> On Sat, Sep 17, 2022 at 4:39 AM Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
> 
> > Add the missing destroy_workqueue() before return from ocelot_pinctrl_probe()
> > in error path.
> >
> > Fixes: c297561bc98a ("pinctrl: ocelot: Fix interrupt controller")
> > Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> > ---
> > v2:
> >   move alloc_ordered_workqueue() after ocelot_pinctrl_register().
> 
> Horatiu does this v2 look like you want it? Reviewed-by?

I have noticed that Yang has sent another version (v3)[1] where he makes
uses of devm_add_action_or_reset.

[1] https://lore.kernel.org/all/20220925021258.1492905-1-yangyingliang@xxxxxxxxxx/T/

> 
> Yours,
> Linus Walleij

-- 
/Horatiu