Re: [PATCH v2 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018

[Neil Armstrong]

On 04/10/2022 10:55, Krzysztof Kozlowski wrote:
> On 04/10/2022 10:08, Neil Armstrong wrote:
> > The PM8018 is used as compatible with PM8921 on the MDM9615, document this situation,
> > and an example section to validate this change.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>

<snip>

> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    ssbi {
> > +      #address-cells = <1>;
> > +      #size-cells = <0>;
> > +      pmic@0 {
> > +        compatible = "qcom,pm8921";
> > +        reg = <0>;
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        interrupt-controller;
> > +        #interrupt-cells = <2>;
> > +
> > +        interrupt-parent = <&tlmm>;
> > +        interrupts = <32 IRQ_TYPE_EDGE_RISING>;
> > +      };
> > +
> > +      pmic@1 {
> > +        compatible = "qcom,pm8018", "qcom,pm8921";
> > +        reg = <1>;
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        interrupt-controller;
> > +        #interrupt-cells = <2>;
> > +
> > +        interrupt-parent = <&tlmm>;
> > +        interrupts = <33 IRQ_TYPE_EDGE_RISING>;
> > +      };
>
> These two pmics are exactly the same (except compatible), so just keep
> one example... unless both are coming from the same, real DTS?

It was mainly to exercise the fallback, but it's useless as-is so I'll remove in v3.

> Best regards,
> Krzysztof

Thanks,
Neil