Re: [PATCH v5 3/3] tty: serial: use uart_port_tx_limited()

From: Ilpo Järvinen
Date: Tue Oct 04 2022 - 07:22:36 EST


On Tue, 4 Oct 2022, Jiri Slaby (SUSE) wrote:

> uart_port_tx_limited() is a new helper to send characters to the device.
> Use it in these drivers.
>
> mux.c also needs to define tx_done(). But I'm not sure if the driver
> really wants to wait for all the characters to dismiss from the HW fifo
> at this code point. Hence I marked this as FIXME.
>
> Cc: Russell King <linux@xxxxxxxxxxxxxxx>
> Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Cc: bcm-kernel-feedback-list@xxxxxxxxxxxx
> Cc: "Pali Rohár" <pali@xxxxxxxxxx>
> Cc: Kevin Cernekee <cernekee@xxxxxxxxx>
> Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx>
> Cc: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> Cc: Orson Zhai <orsonzhai@xxxxxxxxx>
> Cc: Baolin Wang <baolin.wang7@xxxxxxxxx>
> Cc: Chunyan Zhang <zhang.lyra@xxxxxxxxx>
> Cc: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>
> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>

Perhaps you missed this one in the earlier mail. ...Anyway, here it's
again:

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

--
i.