Re: [PATCH v1 3/6] soc: mediatek: mmsys: add support for MT8195 VPPSYS

From: AngeloGioacchino Del Regno
Date: Tue Oct 04 2022 - 08:17:44 EST


Il 04/10/22 11:33, Moudy Ho ha scritto:
From: "Roy-CW.Yeh" <roy-cw.yeh@xxxxxxxxxxxx>

Add MT8195 VPPSYS0 and VPPSYS1 driver data.

Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@xxxxxxxxxxxx>
---
drivers/soc/mediatek/mtk-mmsys.c | 20 +++++++++++++++++++-
drivers/soc/mediatek/mtk-mmsys.h | 1 +
2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
index d2c7a87aab87..c4d15f99f853 100644
--- a/drivers/soc/mediatek/mtk-mmsys.c
+++ b/drivers/soc/mediatek/mtk-mmsys.c
@@ -149,11 +149,25 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = {
.clk_driver = "clk-mt8195-vdo1",
};
+static const struct mtk_mmsys_driver_data mt8195_vppsys0_driver_data = {
+ .io_start = 0x14000000,
+ .clk_driver = "clk-mt8195-vpp0",
+ .is_copies = true,
+};
+
+static const struct mtk_mmsys_driver_data mt8195_vppsys1_driver_data = {
+ .io_start = 0x14f00000,
+ .clk_driver = "clk-mt8195-vpp1",
+ .is_copies = true,
+};
+
static const struct mtk_mmsys_match_data mt8195_mmsys_match_data = {
- .num_drv_data = 2,
+ .num_drv_data = 4,

After a long discussion, it was chosen to not use the io_start way, but to change
the devicetree compatible....

Check this series, and rebase on top of it:
https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097

Cheers,
Angelo

.drv_data = {
&mt8195_vdosys0_driver_data,
&mt8195_vdosys1_driver_data,
+ &mt8195_vppsys0_driver_data,
+ &mt8195_vppsys1_driver_data,
},
};
@@ -360,6 +374,9 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
if (IS_ERR(clks))
return PTR_ERR(clks);
+ if (mmsys->data->is_copies)

I don't get what "is_copies" means, sorry. I'm sure that there's a better name
for this one.

+ goto out_probe_done;
+
drm = platform_device_register_data(&pdev->dev, "mediatek-drm",
PLATFORM_DEVID_AUTO, NULL, 0);
if (IS_ERR(drm)) {

Regards,
Angelo