Re: [PATCH v6 2/5] x86: Add cmdline_prepare() helper

[Evgeniy Baskov]

On 2022-09-30 20:30, Borislav Petkov wrote:
> On Sat, Aug 27, 2022 at 05:08:07AM +0300, Evgeniy Baskov wrote:
> > +/*
> > + * command_line and boot_command_line are expected to be at most
> > + * COMMAND_LINE_SIZE length. command_line needs to be initialized
> > + * with COMMAND_LINE_INIT.
> > + */
> > +static inline void cmdline_prepare(char *command_line,
> > +				   const char *boot_command_line)
> > +{
> > +#ifdef CONFIG_CMDLINE_BOOL
>
> Right, this is an ifdef...
>
> > +	if (!IS_ENABLED(CONFIG_CMDLINE_OVERRIDE)) {
>
> ... but this is a IS_ENABLED().
>
> Why?
>
> I think we should stick to one.

Right, I'll change #ifdef to IS_ENABLED() and resubmit.
Originally it was like that because CONFIG_CMDLINE was used
in one of the #ifdef branches and it's no longer needed.

Thanks,
Evgeniy Baskov