Re: [PATCH 4/5] thermal/core: Move the thermal zone lock out of the governors

[Daniel Lezcano]

On 04/10/2022 16:14, Guenter Roeck wrote:
> On Fri, Aug 05, 2022 at 05:38:33PM +0200, Daniel Lezcano wrote:
> > All the governors throttling ops are taking/releasing the lock at the
> > beginning and the end of the function.
> >
> > We can move the mutex to the throttling call site instead.
> >
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> > ---
> >   drivers/thermal/gov_bang_bang.c       |  4 +---
> >   drivers/thermal/gov_fair_share.c      |  4 +---
> >   drivers/thermal/gov_power_allocator.c | 16 ++++++----------
> >   drivers/thermal/gov_step_wise.c       |  4 +---
> >   drivers/thermal/thermal_core.c        |  2 ++
>
> This doesn't drop the lock from drivers/thermal/gov_user_space.c.
> Is that on purpose ?

No, it is an oversight. It was fixed after by Rafael

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog