Re: [PATCH] net: benet: use snprintf instead sprintf and IFNAMSIZ instead hardcoded constant.

From: Stephen Hemminger
Date: Tue Oct 04 2022 - 11:29:50 EST


On Tue, 4 Oct 2022 12:50:34 +0300
Peter Kosyh <pkosyh@xxxxxxxxx> wrote:

> printf to array 'eqo->desc' of size 32 may cause buffer overflow when
> using non-standard IFNAMSIZ.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Peter Kosyh <pkosyh@xxxxxxxxx>

NACK
Non-standard IFNAMSIZ will break uapi and many things.
I see no reason for kernel or tools like iproute2 to support or
fix those related bugs.