Re: linux-next: Signed-off-by missing for commit in the xfs tree
From: Darrick J. Wong
Date: Tue Oct 04 2022 - 11:57:45 EST
On Tue, Oct 04, 2022 at 10:50:12PM +1100, Stephen Rothwell wrote:
> Hi Dave,
> On Tue, 4 Oct 2022 09:21:03 +1100 Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> > The commit matches exactly what was sent to the list. It's just
> > that the patch was sent from a personal email address with a
> > corporate signoff.
> > Since when has that been an issue? I -personally- have been doing
> > this for well over a decade and I'm pretty sure there are lots of
> > other people who also do this.
> If you are happy (as the maintainer), then fine. My script just could
> not connect those 2 email addresses. I check for matches between the
> address itself (the part between the <>) or a match between the "name"
> part (before the <>). If either matches (or it is obvious) then I
> don't report it.
> I have reported very few of these.
My checkpatch is happier if the whole "name <email>" string matches, but
it'll accept name matches. This ofc rests upon the assumption that
I can spot the deepcake'd Dave Chinners hawking phones in Russia or
That said... I think we should get in the habit of asking patch authors
to make sure that at least one of the email or name strings match
between the From and SOB tags. I can see how people who grok even less
about how Chinese names work than I do (read: lawyers) might get fussy
about this kind of thing.
> > Hence if this is wrong, then we've got a tooling problem with b4.
> > Why does b4 allow this rather than warn/fail if it's not actually
> > allowed in the linux-next tree?
> These reports are more of "is this right/was this a slipup?" rather
> than "this is not allowed" i.e.. there are circumstances under which
> the actual author does not (or cannot) provide a Signed-off-by and that
> is OK.
> Stephen Rothwell