Re: [PATCH v5 12/12] Documentation/x86: Update resctrl_ui.rst for new features
From: Reinette Chatre
Date: Tue Oct 04 2022 - 15:06:02 EST
On 10/4/2022 11:18 AM, Moger, Babu wrote:
> On 10/4/22 11:15, Reinette Chatre wrote:
>> On 10/4/2022 7:00 AM, Moger, Babu wrote:
>>> On 10/3/22 10:36, Reinette Chatre wrote:
>>>> On 10/3/2022 7:28 AM, Moger, Babu wrote:
>>>>> On 9/29/22 17:10, Reinette Chatre wrote:
>>>>>> Hi Babu,
>>>>>> In subject: resctrl_ui.rst -> resctrl.rst
>>>>>> On 9/27/2022 1:27 PM, Babu Moger wrote:
>>> + * However, the hardware team recommends to update the MSR on
>>> + * all the CPU threads. It is not clear in the document yet.
>> To be consistent, could "CPU threads" be "CPUs"?
>> Could you please be specific about which document you refer to? Although,
> I am talking about AMD64 Technology Platform Quality
I know that. I was referring to the text just referring to "the document"
without any indication what document it actually refers to.
> of Service Extensions, Revision: 1.03 Publication # 56375 Revision: 1.03 Issue Date: February 2022".
> Link: https://www.amd.com/en/support/tech-docs/amd64-technology-platform-quality-service-extensions
> Will add this link in the commit message.
Adding the link to the commit message will be helpful to support the
change but it will not help people make sense of terms like "the document"
when reading the comments in the code after the change has been merged.