Re: [PATCH v5 1/5] dt-bindings: phy: rockchip: add PCIe v3 phy
From: Sebastian Reichel
Date: Tue Oct 04 2022 - 16:57:55 EST
On Tue, Oct 04, 2022 at 05:19:11PM +0200, Frank Wunderlich wrote:
> Am 4. Oktober 2022 17:09:29 MESZ schrieb Rob Herring <robh@xxxxxxxxxx>:
> >On Thu, Aug 25, 2022 at 09:38:32PM +0200, Frank Wunderlich wrote:
> >> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> >> +properties:
> >> + compatible:
> >> + enum:
> >> + - rockchip,rk3568-pcie3-phy
> >The driver also has 'rockchip,rk3588-pcie3-phy'. Please send a fix
> >adding it here or removing from the driver. Are they not compatible with
> >each other?
> Right, original driver has rk3588 support,but we can't test it.
> Initialization and lane-mapping (bifurcation) was bit different.
> So we wanted to upstream rk3568 first (but have not removed this
> part from driver).
> I see that someone added rk3588 basic support and if he can test
> rk3588 i can send compatible for it.
Basic rk3588 support is still WIP. At the moment patches for the CRU
are still pending as well as base DT. I hope to land them for v6.2
(so next merge window). At the same time I don't think PCIe support
is realistic before v6.3.
Description: PGP signature