Re: [PATCH] staging: rtl8723bs: Remove redundant initialization of variable efuseValue

[Philipp Hortmann]

On 10/4/22 17:35, Colin Ian King wrote:
> The variable efuseValue is being initialized with a value that is never
> read. The variable is being re-assigned later on. The initialization is
> redundant and can be removed.
>
> Cleans up warning:
> drivers/staging/rtl8723bs/core/rtw_efuse.c:285:6: warning: variable
> 'efuseValue' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
>   drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 06e727ce9cc2..eb848f9bbf2c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -282,7 +282,7 @@ u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoT
>   {
>   	u8 tmpidx = 0;
>   	u8 bResult = false;
> -	u32 efuseValue = 0;
> +	u32 efuseValue;
>   
>   	if (bPseudoTest)
>   		return Efuse_Write1ByteToFakeContent(addr, data);


I propose to remove all lines with efuseValue as it is dead code.

Make a v2 of this patch with version history below the ---

Thanks for your support.

Bye Philipp