Re: [PATCH V2 1/1] x86/sgx: Add code to inject hwpoison into SGX memory

[Jarkko Sakkinen]

On Sun, Oct 02, 2022 at 02:51:22PM +0000, Thomas Tai wrote:
> 
> > -----Original Message-----
> > From: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
> > Sent: September 30, 2022 5:51 PM
> > To: Thomas Tai <thomas.tai@xxxxxxxxxx>
> > Cc: tony.luck@xxxxxxxxx; dave.hansen@xxxxxxxxxxxxxxx;
> > reinette.chatre@xxxxxxxx; naoya.horiguchi@xxxxxxx; linmiaohe@xxxxxxxxxx;
> > akpm@xxxxxxxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH V2 1/1] x86/sgx: Add code to inject hwpoison into SGX
> > memory
> > 
> > On Wed, Sep 28, 2022 at 11:38:32AM -0400, Thomas Tai wrote:
> > > Inspired by commit c6acb1e7bf46 (x86/sgx: Add hook to error injection
> > > address validation), add a similar code in hwpoison_inject function to
> > > check if the address is located in SGX Memory. The error will then be
> > > handled by the arch_memory_failure function in the SGX driver.
> > >
> > > Signed-off-by: Thomas Tai <thomas.tai@xxxxxxxxxx>
> > > ---
> > >  Documentation/mm/hwpoison.rst | 44
> > +++++++++++++++++++++++++++++++++++
> > >  mm/hwpoison-inject.c          |  4 ++++
> > >  2 files changed, 48 insertions(+)
> > 
> > Hmm.. no change log.
> > 
> > What was the change in-between v1 and v2?
> 
> Hi Jarkko,
> I put the change log in [PATCH V2 0/1]. Following is the details, hope you find it useful.
> 
> Changes since v1:
> - Add a comment in hwpoison_inject as suggested by Miaohe
> - v1: Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>
> - v1: Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> 
> Thanks,
> Thomas

Also,


Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>

BR, Jarkko