Re: [RFC v1 1/1] arm: dts: omap4: pcm959: add initial support for phytec pcm959

[Colin Foster]

Hi Krzysztof,
On Tue, Oct 04, 2022 at 09:04:15AM +0200, Krzysztof Kozlowski wrote:
> On 04/10/2022 04:40, Colin Foster wrote:
> > The Phytec PCM-959 is a development platform for the Phytec PCM-049 SOM.
> > Add initial functionality for the board. The verified interfaces and
> > peripherals are listed below for the SOM (PCM-049) and the dev board
> > (PCM-959)
> > 
> > The omap2plus_defconfig was used for testing. Only the On-board LEDs
> > required CONFIG_LEDS_PCA9532 addition.
> > 
> > PCM-049:
> > i2c1
> >   * EEPROM at 0x50
> >   * TMP102 (hwmon) at 0x4b
> > twl6030
> > GPMC
> >   * Ethernet
> >   * Flash
> > Serial (ttyS2 console)
> > 
> > PCM959:
> > MMC1
> > On-board LEDs (with CONFIG_LEDS_PCA9532)
> > 
> > Signed-off-by: Colin Foster <colin.foster@xxxxxxxxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/Makefile                  |   1 +
> >  arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi | 352 ++++++++++++++++++++
> >  arch/arm/boot/dts/omap4-phytec-pcm-959.dts  | 130 ++++++++
> >  3 files changed, 483 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi
> >  create mode 100644 arch/arm/boot/dts/omap4-phytec-pcm-959.dts
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 27eec8e670ec..ef225150c5d7 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -949,6 +949,7 @@ dtb-$(CONFIG_ARCH_OMAP4) += \
> >  	omap4-panda.dtb \
> >  	omap4-panda-a4.dtb \
> >  	omap4-panda-es.dtb \
> > +	omap4-phytec-pcm-959.dtb \
> >  	omap4-sdp.dtb \
> >  	omap4-sdp-es23plus.dtb \
> >  	omap4-var-dvk-om44.dtb \
> > diff --git a/arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi b/arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi
> > new file mode 100644
> > index 000000000000..05b5cd581f15
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi
> > @@ -0,0 +1,352 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > +		stdout-path = &uart3;
> > +	};
> > +
> > +	leds: leds {
> 
> Does not look like you tested the DTS against bindings. Please run `make
> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
> for instructions).

Ahh, I see that now. I had started with
arch/arm/boot/dts/omap4-panda-{es,common} as my inspiration. I'll review
the documentation and be sure to run make dtbs_check before my next
submission.

And thank you for all your other points. They're all valid, and I'll
be sure to implement all of your suggestions before a future submission.
There isn't much use for me to acknowledge each suggestion one-by-one.


Thank you very much.