Re: [PATCH net-next] net/sock: Introduce trace_sk_data_ready()
From: Peilin Ye
Date: Tue Oct 04 2022 - 20:14:18 EST
On Thu, Sep 29, 2022 at 09:19:34AM -0700, Eric Dumazet wrote:
> I would rather split this in two parts.
>
> First patch adding and using a common helper.
>
> static inline void sock_data_ready(struct sock *sk)
> {
> sk->sk_data_ready(sk);
> }
>
> s/sk->sk_data_ready(sk)/sock_data_ready(sk)/
>
>
> Second patch adding the tracing point once in the helper ?
>
> Alternatively, why not add the tracepoint directly in the called
> functions (we have few of them),
> instead of all call points ?
Thanks for the suggestions. I will move this tracepoint into callees in
v2.
Thanks,
Peilin Ye