Re: [PATCH 2/6] null_blk: allow write zeores on membacked

From: Chaitanya Kulkarni
Date: Wed Oct 05 2022 - 01:11:30 EST


On 10/4/22 21:57, Damien Le Moal wrote:
> On 10/5/22 12:16, Chaitanya Kulkarni wrote:
>> Add a helper functions to enable the REQ_OP_WRITE_ZEROES operations
>> when null_blk is configured with the membacked mode.
>>
>> Since write-zeroes is a non-trivial I/O operation we need this to
>> add a blktest so we can test the non-trivial I/O path from the
>> application to the block layer.
>
> Why a separate patch for this ? Introducing the module argument and
> configfs equivalent separately in 2 different patches is strange and does
> not facilitate review.
>
> This patch should be merged with patch 1.
>

Sounds good will merge it.

-ck