Re: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

From: neil . armstrong
Date: Wed Oct 05 2022 - 03:11:22 EST

On 05/10/2022 08:19, allen.chen@xxxxxxxxxx wrote:

data-lanes is output configuration. Maybe it is not suitable to put data-lanes in input endpoint.
extcon doesn't have output endpoint, so I don't know where to put is better.

Ok it wasn't clear enough

Then rename the property to something more specific like:

Use the same naming scheme for the other property:


-----Original Message-----
From: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
Sent: Thursday, September 29, 2022 4:40 PM
To: Allen Chen (陳柏宇) <allen.chen@xxxxxxxxxx>
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; Kenneth Hung (洪家倫) <Kenneth.Hung@xxxxxxxxxx>; Jernej Skrabec <jernej.skrabec@xxxxxxxxx>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Jau-Chih Tseng (曾昭智) <Jau-Chih.Tseng@xxxxxxxxxx>; David Airlie <airlied@xxxxxxxx>; open list:DRM DRIVERS <dri-devel@xxxxxxxxxxxxxxxxxxxxx>; Neil Armstrong <narmstrong@xxxxxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx>; Robert Foss <robert.foss@xxxxxxxxxx>; Pin-yen Lin <treapking@xxxxxxxxxxxx>; Hermes Wu (吳佳宏) <Hermes.Wu@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>; Andrzej Hajda <andrzej.hajda@xxxxxxxxx>; Jonas Karlman <jonas@xxxxxxxxx>
Subject: Re: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth


On 29/09/2022 03:44, allen wrote:
From: allen chen <allen.chen@xxxxxxxxxx>

Add properties to restrict dp output data-lanes and clock.

Signed-off-by: Pin-Yen Lin <treapking@xxxxxxxxxxxx>
Signed-off-by: Allen Chen <allen.chen@xxxxxxxxxx>
.../devicetree/bindings/display/bridge/ite,it6505.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git
index 833d11b2303a..62b9f2192202 100644
--- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
@@ -52,6 +52,14 @@ properties:
maxItems: 1
description: extcon specifier for the Power Delivery
+ data-lanes:
+ maxItems: 1
+ description: restrict the dp output data-lanes with value of 1-4

Can't you use the data-lanes property in the first port endpoint ?

Look at Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml

+ max-pixel-clock-khz:
+ maxItems: 1
+ description: restrict max pixel clock

New vendor specific properties should have the ite, prefix.

$ref: /schemas/graph.yaml#/properties/port
description: A port node pointing to DPI host port node @@ -84,6
+92,8 @@ examples:
pwr18-supply = <&it6505_pp18_reg>;
reset-gpios = <&pio 179 1>;
extcon = <&usbc_extcon>;
+ data-lanes = <2>;
+ max-pixel-clock-khz = <150000>;
port {
it6505_in: endpoint {