Re: [perf bench syscall] c5ba0666d8: perf-sanity-tests.perf.make_fail

From: Tiezhu Yang
Date: Wed Oct 05 2022 - 10:06:07 EST

On 10/5/22 16:35, kernel test robot wrote:

FYI, we noticed the following commit (built with gcc-11):

commit: c5ba0666d8f6dd34cb07ad45804e6a90159d377f ("[PATCH v2 1/3] perf bench syscall: Introduce bench_syscall_common()")
base: perf/core
patch link:

in testcase: perf-sanity-tests
version: perf-x86_64-b357fd1c2afc-1_20221001
with following parameters:

perf_compiler: gcc

on test machine: 8 threads 1 sockets Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (Kaby Lake) with 32G memory

caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):

CC bench/syscall.o
bench/syscall.c: In function ‘bench_syscall_common’:
bench/syscall.c:47:8: error: ‘__NR_getppid’ undeclared (first use in this function); did you mean ‘__getpgid’?
47 | case __NR_getppid:
| ^~~~~~~~~~~~
| __getpgid
bench/syscall.c:47:8: note: each undeclared identifier is reported only once for each function it appears in
bench/syscall.c: In function ‘bench_syscall_basic’:
bench/syscall.c:102:42: error: ‘__NR_getppid’ undeclared (first use in this function); did you mean ‘__getpgid’?
102 | return bench_syscall_common(argc, argv, __NR_getppid);
| ^~~~~~~~~~~~
| __getpgid
bench/syscall.c:103:1: error: control reaches end of non-void function [-Werror=return-type]
103 | }
| ^
cc1: all warnings being treated as errors

If you fix the issue, kindly add following tag
| Reported-by: kernel test robot <yujie.liu@xxxxxxxxx>
| Link:

To reproduce:

git clone
cd lkp-tests
sudo bin/lkp install job.yaml # job file is attached in this email
bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
sudo bin/lkp run generated-yaml-file

# if come across any failure that blocks the test,
# please remove ~/.lkp and /lkp dir to run from a clean state.

I am sorry for the build issues.

In my opinion, include asm/unistd.h can fix the build error about
undeclared __NR_getppid reported by kernel test robot, and this is
what I did in the v2 patch, but it seems no effect.

Here are the definition on my x86_64 system:

[yangtiezhu@linux ~]$ grep -rn __NR_getppid /usr/include/
/usr/include/asm/unistd_x32.h:102:#define __NR_getppid (__X32_SYSCALL_BIT + 110)
/usr/include/asm/unistd_32.h:68:#define __NR_getppid 64
/usr/include/asm/unistd_64.h:114:#define __NR_getppid 110
/usr/include/asm-generic/unistd.h:492:#define __NR_getppid 173
/usr/include/asm-generic/unistd.h:493:__SYSCALL(__NR_getppid, sys_getppid)
/usr/include/bits/syscall.h:610:#ifdef __NR_getppid
/usr/include/bits/syscall.h:611:# define SYS_getppid __NR_getppid
[yangtiezhu@linux ~]$ cat /usr/include/asm/unistd.h
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
#ifndef _ASM_X86_UNISTD_H
#define _ASM_X86_UNISTD_H

/* x32 syscall flag bit */
#define __X32_SYSCALL_BIT 0x40000000

# ifdef __i386__
# include <asm/unistd_32.h>
# elif defined(__ILP32__)
# include <asm/unistd_x32.h>
# else
# include <asm/unistd_64.h>
# endif

#endif /* _ASM_X86_UNISTD_H */
[yangtiezhu@linux ~]$ rpm -qf /usr/include/asm/unistd.h

In order to fix the build error,

(1) Maybe I need to add the following code like

#ifndef __NR_getppid
# if defined(__i386__)
# define __NR_getppid 64
# elif defined(__x86_64__)
# define __NR_getppid 110
# elif defined(__aarch64__)
# elif defined(__sparc__)
# elif defined(__s390__)
# elif defined(__mips__)
# else
# error __NR_getppid not defined.
# endif

(2) Maybe I need to modify the following header files:

I prefer the second method, but I am a bit confused,
why not include /usr/include/asm/unistd*.h?
I think it is to avoid cross build issues?
Am I missing something?

Let me rethink it and then send v3, thank you.