Re: [PATCH v6 2/4] can: esd: add support for esd GmbH PCIe/402 CAN interface family

From: Marc Kleine-Budde
Date: Wed Oct 05 2022 - 12:04:17 EST


On 30.09.2022 22:15:59, Stefan Mätje wrote:
> I would like to resume the efforts to bring this driver in the Linux
> kernel after being kicked off track in February by another project.

\o/

> I did a lot of the changes on the driver you recommended, but some
> stuff is not yet clear to me. Please see my comments in-line of the
> email below.
>
> My local developement is at the moment rebased to
> linux-can-next:master on 7b584fbb36362340a2d9cfe459e447619eecebea.
> Should I send a V7 of the patch (rebased to another commit)? How
> should I proceed?

You can use latest net-next/main as base version.

> You have commented on many type casts that they would not be needed.
> But all of them had been introduced by me due to warnings of the
> compiler in the style of "warning: conversion from ‘u32’ {aka
> ‘unsigned int’} to ‘u8’ {aka ‘unsigned char’} may change value
> [-Wconversion]". These are triggered by building the driver with "W=3"
> as recommended in kernel documentation.

Oh? Is there a recommendation for W=3? I can only find a W=1:

| https://elixir.bootlin.com/linux/v6.0/source/Documentation/process/maintainer-netdev.rst#L235

> Should these warnings generally be ignored and the casts be removed
> then?

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature