Re: [PATCH v6 1/3] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker

From: Doug Anderson
Date: Wed Oct 05 2022 - 12:44:14 EST


Hi,

On Mon, Oct 3, 2022 at 3:28 AM Sheng-Liang Pan
<sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> evoker will have WIFI/LTE SKU, separate it for each different setting.
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
>
> (no changes since v5)
>
> Changes in v5:
> - new patch add touchpad and touchscreen for evoker
> - remove unnecessary whitespace
>
> Changes in v4:
> - fix typo in tittle and commit
> - remove change for trackpad and touchscreen

No need to spin for this purpose, but your version history is a bit
confusing here. You should be putting the version history in the patch
that changed. In this case the bindings patch (patch #1) didn't change
in v5 and the trackpad/touchscreen didn't change in v4. Those changes
were in patches #2 and #3.

-Doug