Re: [PATCH v4 2/7] Enable balloon drivers to report inflated memory
From: Nadav Amit
Date: Wed Oct 05 2022 - 13:25:58 EST
On Oct 5, 2022, at 2:01 AM, Alexander Atanasov <alexander.atanasov@xxxxxxxxxxxxx> wrote:
> Add counters to be updated by the balloon drivers.
> Create balloon notifier to propagate changes.
I missed the other patches before (including this one). Sorry, but next
time, please cc me.
I was looking through the series and I did not see actual users of the
notifier. Usually, it is not great to build an API without users.
> +static int balloon_notify(unsigned long val)
> + return srcu_notifier_call_chain(&balloon_chain, val, NULL);
Since you know the inflated_kb value here, why not to use it as an argument
to the callback? I think casting to (void *) and back is best. But you can
also provide pointer to the value. Doesn’t it sound better than having
potentially different notifiers reading different values?
Anyhow, without users (actual notifiers) it’s kind of hard to know how
reasonable it all is. For instance, is it balloon_notify() supposed to
prevent further balloon inflating/deflating until the notifier completes?
Accordingly, are callers to balloon_notify() expected to relinquish locks
before calling balloon_notify() to prevent deadlocks and high latency?