Re: [GIT PULL] Backlight for v6.1
From: Linus Torvalds
Date: Wed Oct 05 2022 - 14:00:01 EST
On Wed, Oct 5, 2022 at 5:44 AM Lee Jones <lee@xxxxxxxxxx> wrote:
> - Add support for MediaTek MT6370 Backlight
Hmm. This new driver has a
depends on MFD_MT6370
but there is no such symbol anywhere.
It turns out the same is true of the MT6370 regulator driver that was
added during the previous merge window.
I do see that MFD_MT6370 in linux-next, but I don't see any pull
request for this, and now that I started looking I do see that we had
this already in 6.0.
I do *not* believe that it's ok to randomly take "drivers" that depend
on functionality that hasn't even been merged yet, and that are
basically just dead code but hidden away this non-obvious way.
I've pulled this, but I want to just state that this is bad, bad, bad.
If it has dependencies that aren't met, it damn well shouldn't be sent
upstream in a form where upstream can't even build test the thing.