[PATCH v2 0/7] drm/msm: Fix math issues in MSM DSC implementation

From: Marijn Suijten
Date: Wed Oct 05 2022 - 14:17:19 EST

Various removals of complex yet unnecessary math, fixing all uses of
drm_dsc_config::bits_per_pixel to deal with the fact that this field
includes four fractional bits, and finally making sure that
range_bpg_offset contains values 6-bits wide to prevent overflows in

Altogether this series is responsible for solving _all_ Display Stream
Compression issues and artifacts on the Sony Tama (sdm845) Akatsuki
smartphone (2880x1440p).

Changes since v1:

- Propagate r-b's, except (obviously) in patches that were (heavily)
- Remove accidental debug code in dsi_cmd_dma_add;
- Move Range BPG Offset masking out of DCS PPS packing, back into the
DSI driver when it is assigned to drm_dsc_config (this series is now
strictly focusing on drm/msm again);
- Replace modulo-check resulting in conditional increment with
- Remove repeated calculation of slice_chunk_size;
- Use u16 instead of int when handling bits_per_pixel;
- Use DRM_DEV_ERROR instead of pr_err in DSI code;
- Also remove redundant target_bpp_x16 variable.

v1: https://lore.kernel.org/linux-arm-msm/20221001190807.358691-1-marijn.suijten@xxxxxxxxxxxxxx/T/#u

Marijn Suijten (7):
drm/msm/dsi: Remove useless math in DSC calculations
drm/msm/dsi: Remove repeated calculation of slice_per_intf
drm/msm/dsi: Use DIV_ROUND_UP instead of conditional increment on
drm/msm/dsi: Reuse earlier computed dsc->slice_chunk_size
drm/msm/dsi: Account for DSC's bits_per_pixel having 4 fractional bits
drm/msm/dpu1: Account for DSC's bits_per_pixel having 4 fractional
drm/msm/dsi: Prevent signed BPG offsets from bleeding into adjacent

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 11 +----
drivers/gpu/drm/msm/dsi/dsi_host.c | 56 ++++++++++------------
2 files changed, 28 insertions(+), 39 deletions(-)