Re: [PATCH][next] i2c: microchip: pci1xxxx: Fix comparison of -EPERM against an unsigned variable

From: Wolfram Sang
Date: Wed Oct 05 2022 - 14:53:44 EST


On Tue, Oct 04, 2022 at 08:27:15PM +0100, Colin Ian King wrote:
> The comparison of variable ret with -EPERM is always false because
> ret is an u8 type. Fix this by making ret an int.
>
> Cleans up clang warning:
> drivers/i2c/busses/i2c-mchp-pci1xxxx.c:714:10: warning: result of comparison
> of constant -1 with expression of type 'u8' (aka 'unsigned char') is always
> false [-Wtautological-constant-out-of-range-compare]
>
> Fixes: 361693697249 ("i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch")
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Applied to for-current, thanks!

Attachment: signature.asc
Description: PGP signature