Re: mainline build failure due to 81c0386c1376 ("regmap: mmio: Support accelerared noinc operations")
From: Linus Walleij
Date: Wed Oct 05 2022 - 16:04:40 EST
On Wed, Oct 5, 2022 at 12:39 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Wed, Oct 05, 2022 at 07:30:56AM +0100, Sudip Mukherjee (Codethink) wrote:
> > Hi All,
> > The latest mainline kernel branch fails to build alpha allmodconfig
> > with the error:
> > drivers/base/regmap/regmap-mmio.c: In function 'regmap_mmio_noinc_write':
> > drivers/base/regmap/regmap-mmio.c:222:17: error: implicit declaration of function 'writesb'; did you mean 'writeb'? [-Werror=implicit-function-declaration]
> > 222 | writesb(ctx->regs + reg, (const u8 *)val, val_count);
> > | ^~~~~~~
> > | writeb
> I'd forgotten about this one, sorry, and alpha isn't covered by things
> like KernelCI so I didn't see the failure when I checked before sending
> my pull request. It's fixed in -next by 7e772dad9913992 ("alpha: Use
> generic <asm-generic/io.h>") from Linus Walleij which is in the
> asm-generic tree.
There were some further issues with the fix (alpha is really hairy)
but Arnd stepped in and fixed those too, it should all be fixed up when
the arch tree gets pulled.
This was the first time I had to do generic arch maintenance duty so
it was a bit bumpy.