Re: [PATCH v7 3/3] pinctrl: qcom: add sdm670 pinctrl

[Richard Acayan]

> On 04/10/2022 23:58, Richard Acayan wrote:
> > The Snapdragon 670 has a Top-Level Mode Multiplexer (TLMM) for various
> > features. Add a driver to support it.
> 
> (...)
> 
> > +
> > +const int sdm670_reserved_gpios[] = {
> > +	58, 59, 60, 61, 62, 63, 64, 69, 70, 71, 72, 73, 74, 104, -1
> > +};
> > +
> > +static const struct msm_pinctrl_soc_data sdm670_pinctrl = {
> > +	.pins = sdm670_pins,
> > +	.npins = ARRAY_SIZE(sdm670_pins),
> > +	.functions = sdm670_functions,
> > +	.nfunctions = ARRAY_SIZE(sdm670_functions),
> > +	.groups = sdm670_groups,
> > +	.ngroups = ARRAY_SIZE(sdm670_groups),
> > +	.ngpios = 151,
> > +	.reserved_gpios = sdm670_reserved_gpios,
> > +	.complement_fw_gpio_ranges = true,
> 
> This still fails to build... v6 was not compilable, v7 is still.

Sorry, I only see the problem with complement_fw_gpio_ranges being removed from
the struct and not being removed here (in v7). Is there another issue that
affected v6?

> 
> Best regards,
> Krzysztof