Re: [PATCH] PCI: qcom-ep: Fix disabling global_irq in error path
From: Lorenzo Pieralisi
Date: Thu Oct 06 2022 - 02:35:54 EST
On Wed, Oct 05, 2022 at 12:35:29PM -0500, Bjorn Helgaas wrote:
> On Wed, Oct 05, 2022 at 07:28:52PM +0530, Manivannan Sadhasivam wrote:
> > After commit 6a534df3da88 ("PCI: qcom-ep: Disable IRQs during driver
> > remove"), the global irq is stored in the "global_irq" member of pcie_ep
> > structure. This eliminates the need of local "irq" variable but that
> > commit didn't remove the "irq" variable usage completely and it is still
> > used for disable_irq() in error path which is wrong since the variable is
> > uninitialized.
> > Fix this by removing the local "irq" variable and using
> > "pcie_ep->global_irq" for disable_irq() in error path.
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Fixes: 6a534df3da88 ("PCI: qcom-ep: Disable IRQs during driver remove")
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> For today's "next" branch, I dropped 6a534df3da88 and the subsequent
> patches. Hopefully Lorenzo can squash this fix into 6a534df3da88.
Done - the pci/qcom branch successfully passed kbot's tests as well.