Re: [RFT PATCH v3 10/10] iio: Don't silently expect attribute types

From: Claudiu.Beznea
Date: Thu Oct 06 2022 - 04:36:12 EST


On 03.10.2022 11:13, Matti Vaittinen wrote:
> The iio_triggered_buffer_setup_ext() and the
> devm_iio_kfifo_buffer_setup_ext() were changed by
> commit 15097c7a1adc ("iio: buffer: wrap all buffer attributes into iio_dev_attr")
> to silently expect that all attributes given in buffer_attrs array are
> device-attributes. This expectation was not forced by the API - and some
> drivers did register attributes created by IIO_CONST_ATTR().
>
> When using IIO_CONST_ATTRs the added attribute "wrapping" does not copy
> the pointer to stored string constant and when the sysfs file is read the
> kernel will access to invalid location.
>
> Change the function signatures to expect an array of iio_dev_attrs to
> avoid similar errors in the future.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

Tested-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>

on SAMA5D2