Re: [PATCH v2 05/10] dt-bindings: pinctrl: mediatek,pinctrl-mt6795: Fix interrupt count

[Yassine Oudjana]

On Thu, Oct 6 2022 at 11:01:29 AM +0200, AngeloGioacchino Del Regno 
<angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
> Il 05/10/22 19:43, Yassine Oudjana ha scritto:
> > From: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> >
> > The document currently states a maximum of 1 interrupt, but the DT
> > has 2 specified causing a dtbs_check error. Change the limit to 2
> > to pass the check and add a minimum limit.
> >
> > Signed-off-by: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml   | 3 
> > ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml 
> > b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml
> > index 73ae6e11410b..483fcdc60487 100644
> > --- 
> > a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml
> > +++ 
> > b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml
> > @@ -47,7 +47,8 @@ properties:
> >       interrupts:
> >       description: The interrupt outputs to sysirq.
> > -    maxItems: 1
> > +    minItems: 2
> > +    maxItems: 2
> >     # PIN CONFIGURATION NODES
> >   patternProperties:
>
> Nice catch.
> The right thing to do is...
>
>   interrupts:
>     description: The interrupt outputs to sysirq.
>     minItems: 1
>       - description: EINT interrupt
>       - description: EINT event_b interrupt

I didn't know what the interrupts where exactly and if either one is 
optional so just to be safe I set the limit to 2. I'll do that nex time.

Thanks,
Yassine
>