Re: [PATCH] spi-nand: add Winbond W25N02KV flash support, fix Winbond flashes identifications

From: Frieder Schrempf
Date: Thu Oct 06 2022 - 05:27:09 EST

Am 06.10.22 um 05:32 schrieb mikhail.kshevetskiy@xxxxxxxxx:
> From: Mikhail Kshevetskiy <mikhail.kshevetskiy@xxxxxxxxx>
> Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1,
> but current driver uses only first 2 bytes of it for devices
> idenfification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22)
> is identified as W25N01GV (id_bytes: EF, AA, 21).
> Fix this and add W25N02KV flash support.
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@xxxxxxxxx>

Thanks for the patch. We have a similar change in our downstream kernel,
that I failed to push upstream so far. But your version looks even better.

Can you change the subject prefix to "mtd: spinand: winbond:", please?

And I also would like to ask you to split this into two patches. The
first one to add the third byte in the ids of the existing devices and
the second one to add support for the new device.

With these two changes you can add:

Reviewed-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>