Re: [PATCH v2 1/2] device property: Introduce fwnode_device_is_compatible() helper
From: Andy Shevchenko
Date: Thu Oct 06 2022 - 08:34:24 EST
On Wed, Oct 05, 2022 at 09:05:54PM +0000, Sakari Ailus wrote:
> On Wed, Oct 05, 2022 at 06:29:46PM +0300, Andy Shevchenko wrote:
> fwnode_property_match_string() returns zero on success, therefore >= 0 is
> not needed. I'd just use !fwnode_property_match_string(...).
No, it's bug in the documentation, thanks to rising an attention,
I forgot to send a fix for it earlier.
> For both patches:
> Reviewed-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Thanks, but as stated above the condition in my patch is correct.
It seems due to documentation bug we have some kind of "buggy" code,
luckily not too many to fix.
That said, I'm not going to resend this until PPC (Freescale) maintainers
ask for it. Yang, what's your vision on this series?
With Best Regards,